Skip to content

✨ Remove django.contrib.sites#554

Merged
stevenbal merged 1 commit intomasterfrom
feature/remove-django-contrib-sites
Apr 1, 2025
Merged

✨ Remove django.contrib.sites#554
stevenbal merged 1 commit intomasterfrom
feature/remove-django-contrib-sites

Conversation

@danielmursa-dev
Copy link
Contributor

@danielmursa-dev danielmursa-dev commented Mar 19, 2025

Partially fixed maykinmedia/open-api-framework#59

  • Upgrade open-api-framework==0.9.6
  • Upgrade notifications-api-common==0.7.2
  • Upgrade commonground-api-common==2.5.5
  • Check docs
  • Delete django_setup_configuration for site
  • Remove from INSTALLED_APPS
  • Remove from Admin
  • Revert QRGeneratorView, tests and url

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.57%. Comparing base (959e424) to head (d270946).

Files with missing lines Patch % Lines
src/objects/utils/__init__.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #554      +/-   ##
==========================================
+ Coverage   94.53%   94.57%   +0.04%     
==========================================
  Files         144      144              
  Lines        4938     4938              
==========================================
+ Hits         4668     4670       +2     
+ Misses        270      268       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danielmursa-dev danielmursa-dev force-pushed the feature/remove-django-contrib-sites branch 2 times, most recently from c6d38b0 to 41a3598 Compare March 24, 2025 08:39
@danielmursa-dev danielmursa-dev force-pushed the feature/remove-django-contrib-sites branch 3 times, most recently from f4b110e to 4879acf Compare March 25, 2025 15:22
@stevenbal stevenbal marked this pull request as draft March 28, 2025 11:11
@danielmursa-dev danielmursa-dev force-pushed the feature/remove-django-contrib-sites branch 2 times, most recently from b8687ea to b3b7e2e Compare March 28, 2025 15:37
@danielmursa-dev danielmursa-dev marked this pull request as ready for review March 28, 2025 15:52
@danielmursa-dev danielmursa-dev force-pushed the feature/remove-django-contrib-sites branch from b3b7e2e to f47f6d0 Compare March 31, 2025 09:06
@Floris272 Floris272 mentioned this pull request Mar 31, 2025
12 tasks
@danielmursa-dev danielmursa-dev force-pushed the feature/remove-django-contrib-sites branch from f47f6d0 to 482c90e Compare March 31, 2025 13:00
@danielmursa-dev danielmursa-dev force-pushed the feature/remove-django-contrib-sites branch from 482c90e to d270946 Compare March 31, 2025 14:14
@stevenbal stevenbal merged commit 0d42890 into master Apr 1, 2025
21 checks passed
@stevenbal stevenbal deleted the feature/remove-django-contrib-sites branch April 1, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove django.contrib.sites dependency for all components

3 participants